CI | add :types to query_option so dialyzer is happy #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
reviewed
Jan 5, 2025
lib/ch.ex
Outdated
| @@ -55,6 +55,7 @@ defmodule Ch do | |||
| | {:command, Ch.Query.command()} | |||
| | {:headers, [{String.t(), String.t()}]} | |||
| | {:format, String.t()} | |||
| | {:types, [String.t()]} | |||
There was a problem hiding this comment.
👋
Suggested change
| | {:types, [String.t()]} | |
| | {:types, [String.t() | atom | tuple]} |
Or maybe we can add something like Ch.Types.t or Ch.RowBinary.type and use it here.
@type t ::
:boolean
| :string | {:fixed_string, size :: integer}
| :u8 | :u16 | :u32 | :u64 | :u128 | :u256
| :i8 | :i16 | :i32 | :i64 | :i128 | :i256
| :f32 | :f64
| :date | :date32
| :datetime | {:datetime, timezone :: String.t()} | {:datetime64, precision :: integer, timezone :: String.t()}
| :uuid
| :ipv4 | :ipv6
| :point | :ring | :polygon | :multipolygon
| :nothing
| {:array, t}
| {:tuple, [t]}
| {:map, t, t}
| {:nullable, t}
| {:low_cardinality, t}
| {:simple_aggregate_function, name :: String.t(), t}
| {:decimal, precision :: integer, scale :: integer} | {:decimal32, scale :: integer} | {:decimal64, scale :: integer} | {:decimal128, scale :: integer} | {:decimal256, scale :: integer}
| {:enum8, mapping :: [{name :: String.t(), value :: integer}]} | {:enum16, mapping :: [{name :: String.t(), value :: integer}]}and then
@type query_option ::
# ...
| {:types, [String.t() | Ch.Types.t()]}
# ...There was a problem hiding this comment.
yep, second option looks nicer, but I'm not sure on how to implement it.. whatever works for you 😄
Co-authored-by: ruslandoga <[email protected]>
|
@addUsername thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for your awesome library!!
I've just update it to last version and everything works except the CI, dialyzer fails because
:types(opt needed whenRowBinary) is not included inquery_optionBefore this commit dialyzer fails with:
now it is happy:
I hope i didn't mess up somewhere 😄